Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mikrotik routeros - firewall filter - Add src mac address, correct ipv6 path and empty log prefix #1172

Merged

Conversation

elavaud
Copy link
Contributor

@elavaud elavaud commented Jul 22, 2022

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

Mikrotik routeros
ip firewall filter print all without-paging

SUMMARY
  • Adding "source mac address" field to template
  • ipv6 firewall command does not have the "all" in it
  • log_prefix field can be empty but still be specified in output

Copy link
Contributor

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another PR that got in caused a conflict. I believe that the proposed changes would cover that?

@jvanderaa jvanderaa added the changes_requested Waiting on user to address feedback label Dec 24, 2022
@elavaud elavaud force-pushed the mikrotik-firewall-mac-and-ipv6 branch from 1d03ede to 1dc647f Compare January 27, 2023 06:36
@elavaud elavaud requested review from jvanderaa and removed request for itdependsnetworks, jmcgill298 and FragmentedPacket January 27, 2023 06:37
@jvanderaa jvanderaa merged commit c9a1ad8 into networktocode:master Mar 5, 2023
pszulczewski pushed a commit that referenced this pull request Apr 12, 2023
…v6 path and empty log prefix (#1172)

Co-authored-by: Edouard Lavaud <[email protected]>
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
@k-ribot k-ribot deleted the mikrotik-firewall-mac-and-ipv6 branch June 20, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes_requested Waiting on user to address feedback josh-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants