Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #1024 - Moved Record to Device ID #1039

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Conversation

Niltak
Copy link
Contributor

@Niltak Niltak commented Dec 9, 2021

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT

ntc_templates/templates/cisco_nxos_show_cdp_neighbors_detail.textfsm

SUMMARY - fixed #1024 - Moved Record to Device ID:

Moving the record from the dashes to a continued 'Device ID'. This will fix the issue while maintaining the current output expectation.

Please see expected code output in:
#1024 (comment)

Moved Record to Device ID from ----
…l---moving-record

fixed networktocode#1024 - Moved Record to Device ID
@jvanderaa
Copy link
Contributor

CI does not appear to be kicking off appropriately for this. @jmcgill298 @FragmentedPacket I ran this PR through Tox and everything is passing.

============================================================ 1198 passed in 16.66s ============================================================
py39 create: /home/joshv/projects/ntc-templates/.tox/py39
SKIPPED: InterpreterNotFound: python3.9
black inst-nodeps: /home/joshv/projects/ntc-templates/.tox/.tmp/package/1/ntc_templates-3.0.0.tar.gz
black installed: black==21.11b1,click==8.0.3,future==0.18.2,mypy-extensions==0.4.3,ntc-templates @ file:///home/joshv/projects/ntc-templates/.tox/.tmp/package/1/ntc_templates-3.0.0.tar.gz,pathspec==0.9.0,platformdirs==2.4.0,regex==2021.11.10,six==1.16.0,textfsm==1.1.2,tomli==1.2.2,typing-extensions==4.0.0
black run-test-pre: PYTHONHASHSEED='2332536627'
black run-test: commands[0] | black ./ --diff --check
All done! ✨ 🍰 ✨
8 files would be left unchanged.
flake8 inst-nodeps: /home/joshv/projects/ntc-templates/.tox/.tmp/package/1/ntc_templates-3.0.0.tar.gz
flake8 installed: flake8==4.0.1,future==0.18.2,mccabe==0.6.1,ntc-templates @ file:///home/joshv/projects/ntc-templates/.tox/.tmp/package/1/ntc_templates-3.0.0.tar.gz,pycodestyle==2.8.0,pyflakes==2.4.0,six==1.16.0,textfsm==1.1.2
flake8 run-test-pre: PYTHONHASHSEED='2332536627'
flake8 run-test: commands[0] | flake8 ./
yamllint inst-nodeps: /home/joshv/projects/ntc-templates/.tox/.tmp/package/1/ntc_templates-3.0.0.tar.gz
yamllint installed: future==0.18.2,ntc-templates @ file:///home/joshv/projects/ntc-templates/.tox/.tmp/package/1/ntc_templates-3.0.0.tar.gz,pathspec==0.9.0,PyYAML==6.0,six==1.16.0,textfsm==1.1.2,yamllint==1.26.3
yamllint run-test-pre: PYTHONHASHSEED='2332536627'
yamllint run-test: commands[0] | yamllint ./
___________________________________________________________________ summary ___________________________________________________________________
SKIPPED:  py36: InterpreterNotFound: python3.6
SKIPPED:  py37: InterpreterNotFound: python3.7
  py38: commands succeeded
SKIPPED:  py39: InterpreterNotFound: python3.9
  black: commands succeeded
  flake8: commands succeeded
  yamllint: commands succeeded
  congratulations :)

@Niltak
Copy link
Contributor Author

Niltak commented Mar 18, 2022

Added tests for the changes. Sorry this wasn't done sooner.

@Niltak
Copy link
Contributor Author

Niltak commented Mar 29, 2022

@jvanderaa Updated

@jvanderaa jvanderaa merged commit 73821b2 into networktocode:master Mar 29, 2022
guillaume-mbali pushed a commit to unyc-io/ntc-templates that referenced this pull request Apr 12, 2023
)

Moving the record from the dashes to a continued 'Device ID'. This will fix the issue while maintaining the current output expectation.
cppmonkey pushed a commit to cppmonkey/ntc-templates that referenced this pull request Oct 25, 2023
)

Moving the record from the dashes to a continued 'Device ID'. This will fix the issue while maintaining the current output expectation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cisco nxos template (show cdp neighbors detail) broken with c7710
2 participants