Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to raise custom exception #369

Closed
jmcgill298 opened this issue Feb 3, 2019 · 0 comments · Fixed by #1682
Closed

Need to raise custom exception #369

jmcgill298 opened this issue Feb 3, 2019 · 0 comments · Fixed by #1682
Labels
enhancement PR Required

Comments

@jmcgill298
Copy link
Contributor

ntc-templates/ntc_templates/parse.py

Line 38 in 923f9af

raise Exception('Unable to parse command "%s" on platform %s - %s' % (command, platform, str(e)))

Currently parse_output raises a generic Exception; this needs to be changed to a custom exception that can be properly caught by users of the function.
Kircheneer added a commit to Kircheneer/ntc-templates that referenced this issue Apr 4, 2024
@Kircheneer
raises custom exception on parsing error
0b00bb9 
Caution: This is technically a breaking change.

Closes networktocode#369
@Kircheneer Kircheneer mentioned this issue Apr 4, 2024
Merged
Kircheneer added a commit to Kircheneer/ntc-templates that referenced this issue Apr 4, 2024
@Kircheneer
raises custom exception on parsing error
f0d64dd 
Caution: This is technically a breaking change.

Closes networktocode#369
Kircheneer added a commit to Kircheneer/ntc-templates that referenced this issue Apr 5, 2024
@Kircheneer
raises custom exception on parsing error
05f40f4 
Caution: This is technically a breaking change.

Closes networktocode#369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement PR Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raises custom exception on parsing error Kircheneer/ntc-templates
2 participants
@jmcgill298 @FragmentedPacket