Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude config context from devices list request in NetBox by default #62

Merged
merged 1 commit into from
May 5, 2020

Conversation

dgarros
Copy link
Contributor

@dgarros dgarros commented May 5, 2020

By default, NetBox is returning the config_context with the devices when querying the devices list in the API. When the list of devices is large, the config context can add a significant delay.

Since we are not leveraging information from the config context right now in the inventory, it's preferable to exclude the config context by default when we are querying the list of devices to improve the response time

This PR exclude the config context by default in the NetBox inventory

@lampwins
Copy link

lampwins commented May 5, 2020

Not at all precluding this PR, but keep an eye on netbox-community/netbox#4559 which is meant to address performance issues with rendering of config context.

@dgarros
Copy link
Contributor Author

dgarros commented May 5, 2020

thanks @lampwins, good to know

@dgarros dgarros merged commit 81af147 into develop May 5, 2020
@dgarros dgarros deleted the dga-nb-inventory-exclude-context branch May 28, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants