Fixing napalm extra args validation #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #291
Trying to pass napalm specific options using [network.napalm_extras] in the network_importer.toml file, throws the following error:
It seems the problem is the code in the exactly the highlighted line:
network-importer/network_importer/inventory.py
Line 85 in 9e36624
isintance() should receive the object first and the type we are trying to assess as a second argument. That order is inverted and
dict
is passed as the first argument, whereasself.global_group.connection_options["napalm"].extras
is the second.I can see the same thing happening in line 90 again, by the way.