Don't call resolver if domain is already resolved #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Popov <[email protected]>
denis-tingaikin
requested changes
Jan 27, 2021
|
|
||
| u, err := url.Parse(fmt.Sprintf("tcp://%v:%v", ips[0].IP, records[0].Port)) | ||
| var resolvedPattern = regexp.MustCompile("tcp://(?P<addr>[0-9.:]+):(?P<port>[0-9]+)?") |
There was a problem hiding this comment.
Can we just try to parse resolved domain as a URL to check is it resolved?
There was a problem hiding this comment.
Nope, any domain is most possible a valid URL. We need a domain in tcp://ip:port format.
There was a problem hiding this comment.
Lets then check that part in URL after the scheme is a valid IP and PORT.
You could split Path into two strings entry to parse parts with default parsers for IP and int
denis-tingaikin
requested changes
Jan 27, 2021
| serviceDomain := fmt.Sprintf("%v.%v", service, domain) | ||
| _, records, err := r.LookupSRV(ctx, service, "tcp", serviceDomain) | ||
| var resolved string | ||
| if isResolved(domain) { |
There was a problem hiding this comment.
please move this check to top-level before call resolve domain.
|
|
||
| u, err := url.Parse(fmt.Sprintf("tcp://%v:%v", ips[0].IP, records[0].Port)) | ||
| var resolvedPattern = regexp.MustCompile("tcp://(?P<addr>[0-9.:]+):(?P<port>[0-9]+)?") |
There was a problem hiding this comment.
Lets then check that part in URL after the scheme is a valid IP and PORT.
You could split Path into two strings entry to parse parts with default parsers for IP and int
Signed-off-by: Vladimir Popov <[email protected]>
denis-tingaikin
approved these changes
Jan 27, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jan 27, 2021
…k@master networkservicemesh/sdk#677 networkservicemesh/sdk PR link: networkservicemesh/sdk#677 networkservicemesh/sdk commit message: commit cefb0ac33f42abd4b175cdc25184e1d78abe2d87 Author: Vladimir Popov <[email protected]> Date: Wed Jan 27 14:18:11 2021 +0700 Don't call resolver if domain is already resolved (#677) * Don't call resolver if domain is already resolved Signed-off-by: Vladimir Popov <[email protected]> * Rework isResolved() to parseIPPort() Signed-off-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is no need to call resolver if domain is already in
tcp://${addr}:${port}format.