Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set back nse@domain name on return from interdomainURLServer #605

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Set back nse@domain name on return from interdomainURLServer #605

merged 1 commit into from
Nov 25, 2020

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Nov 25, 2020 •
edited
Loading

Issue

interdomainURLServer updates Request.Connection.NetworkServiceEndpointName from [email protected] to nse and doesn't set it back to the returned Connection. If no one before in the chain saves full name, @domain.url will be lost and refresh request will be trying to find nse locally until timeout.

Solution

Set Connection.NetworkServiceEndpointName = interDomainNSEName on return.

@Bolodya1997 Bolodya1997 marked this pull request as draft November 25, 2020 04:35
@Bolodya1997 Bolodya1997 marked this pull request as ready for review November 25, 2020 05:07
@denis-tingaikin
Copy link
Member

denis-tingaikin commented Nov 25, 2020 •
edited
Loading

refresh request will be trying to find nse locally until timeout.

Not sure about that. It is already covered by test: https://github.com/networkservicemesh/sdk/blob/master/pkg/networkservice/chains/nsmgrproxy/server_test.go#L86

denis-tingaikin
denis-tingaikin approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks like it is needed for new connect approach.

@denis-tingaikin denis-tingaikin merged commit f3c3c51 into networkservicemesh:master Nov 25, 2020
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7f95fd1 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
74ec84c 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
841e154 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4786ea9 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6dbfe5c 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2a922ef 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 25, 2020
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a1d3013 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 25, 2020
Merged
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Nov 25, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fc52672 
…k@master networkservicemesh/sdk#605

networkservicemesh/sdk PR link: networkservicemesh/sdk#605

networkservicemesh/sdk commit message:
commit f3c3c51c88e2456011d1a6075a8556d768574c4c
Author: Vladimir Popov <[email protected]>
Date:   Wed Nov 25 13:02:48 2020 +0700

    Set back nse@domain name on return from interdomainURLServer (#605)

    Signed-off-by: Vladimir Popov <[email protected]>

Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 25, 2020
Merged
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Set back nse@domain name on return from interdomainURLServer (network…
0142c73 
…servicemesh#605)

Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Sergey Ershov <[email protected]>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Set back nse@domain name on return from interdomainURLServer (network…
5fa0b29 
…servicemesh#605)

Signed-off-by: Vladimir Popov <[email protected]>
Signed-off-by: Sergey Ershov <[email protected]>
@Bolodya1997 Bolodya1997 deleted the fix-interdomain branch January 20, 2021 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @denis-tingaikin