Leak fixes #1643

NikitaSkrynnik · 2024-06-26T12:47:37Z

Description

Issue link

How Has This Been Tested?

Added unit testing to cover
Tested manually
Tested by integration testing
Have not tested

Types of changes

Signed-off-by: Denis Tingaikin <[email protected]>

pkg/networkservice/common/monitor/eventloop.go

pkg/networkservice/common/monitor/server.go

pkg/networkservice/common/updatepath/client.go

Signed-off-by: NikitaSkrynnik <[email protected]>

denis-tingaikin

Other changes look good.

Also, please add a unit test to have regression coverage. Thanks.

pkg/networkservice/common/monitor/client_filter.go

Signed-off-by: NikitaSkrynnik <[email protected]>

codecov · 2024-07-05T07:15:40Z

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@50c0908). Learn more about missing BASE report.

Files	Patch %	Lines
pkg/networkservice/common/monitor/eventloop.go	83.33%	4 Missing and 1 partial ⚠️
pkg/networkservice/common/monitor/client_filter.go	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1643   +/-   ##
=======================================
  Coverage        ?   68.64%           
=======================================
  Files           ?      257           
  Lines           ?    12083           
  Branches        ?        0           
=======================================
  Hits            ?     8294           
  Misses          ?     3293           
  Partials        ?      496

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: NikitaSkrynnik <[email protected]>

…k@main PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) Signed-off-by: Denis Tingaikin <[email protected]> * fix monitor Signed-off-by: NikitaSkrynnik <[email protected]> * fix CI Signed-off-by: NikitaSkrynnik <[email protected]> * add unit tests + fix some errors Signed-off-by: NikitaSkrynnik <[email protected]> * add unit tests Signed-off-by: NikitaSkrynnik <[email protected]> * fix CI Signed-off-by: NikitaSkrynnik <[email protected]> * cleanup Signed-off-by: NikitaSkrynnik <[email protected]> --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-nse-vlan-vpp@main PR link: networkservicemesh/cmd-nse-vlan-vpp#487 Commit: b47658c Author: Network Service Mesh Bot Date: 2024-08-01 04:34:22 -0500 Message: - Update from update/networkservicemesh/sdk-vpp (#487) * Update go.mod and go.sum to latest version from networkservicemesh/sdk-vpp@main PR link: networkservicemesh/sdk-vpp#840 Commit: 9d48d2c Author: Network Service Mesh Bot Date: 2024-08-01 04:27:47 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#840) PR link: networkservicemesh/sdk-kernel#670 Commit: 418a2f4 Author: Network Service Mesh Bot Date: 2024-08-01 04:21:54 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#670) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> * Automatically resolving conflicts in go.mod and updating dependency versions to the latest Signed-off-by: NSMBot <[email protected]> --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#390 Commit: 75ef5a8 Author: Network Service Mesh Bot Date: 2024-08-01 04:34:23 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#390) PR link: networkservicemesh/sdk-ovs#331 Commit: 822a437 Author: Network Service Mesh Bot Date: 2024-08-01 04:29:41 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#331) PR link: networkservicemesh/sdk-sriov#601 Commit: 4e7ad9f Author: Network Service Mesh Bot Date: 2024-08-01 04:26:01 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#601) PR link: networkservicemesh/sdk-kernel#670 Commit: 418a2f4 Author: Network Service Mesh Bot Date: 2024-08-01 04:21:54 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#670) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-forwarder-ovs@main (#12133) PR link: networkservicemesh/cmd-forwarder-ovs#390 Commit: 75ef5a8 Author: Network Service Mesh Bot Date: 2024-08-01 04:34:23 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-ovs@main (#390) PR link: networkservicemesh/sdk-ovs#331 Commit: 822a437 Author: Network Service Mesh Bot Date: 2024-08-01 04:29:41 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-sriov@main (#331) PR link: networkservicemesh/sdk-sriov#601 Commit: 4e7ad9f Author: Network Service Mesh Bot Date: 2024-08-01 04:26:01 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main (#601) PR link: networkservicemesh/sdk-kernel#670 Commit: 418a2f4 Author: Network Service Mesh Bot Date: 2024-08-01 04:21:54 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#670) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-k8s@main PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…k-k8s@main (#468) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-k8s@main (#442) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-k8s@main (#303) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-k8s@main (#751) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-registry-k8s@main PR link: networkservicemesh/cmd-registry-k8s#468 Commit: 13b984d Author: Network Service Mesh Bot Date: 2024-08-05 21:27:32 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#468) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-admission-webhook-k8s@main PR link: networkservicemesh/cmd-admission-webhook-k8s#442 Commit: a8e4892 Author: Network Service Mesh Bot Date: 2024-08-05 21:27:36 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#442) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…k-k8s@main (#339) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…k-k8s@main (#391) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-exclude-prefixes-k8s@main PR link: networkservicemesh/cmd-exclude-prefixes-k8s#303 Commit: 023ef9d Author: Network Service Mesh Bot Date: 2024-08-05 21:27:43 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#303) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-forwarder-sriov@main PR link: networkservicemesh/cmd-forwarder-sriov#751 Commit: 206fb8b Author: Network Service Mesh Bot Date: 2024-08-05 21:27:44 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#751) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-nse-supplier-k8s@main PR link: networkservicemesh/cmd-nse-supplier-k8s#339 Commit: a758049 Author: Network Service Mesh Bot Date: 2024-08-05 21:27:59 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#339) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#391 Commit: 8246645 Author: Network Service Mesh Bot Date: 2024-08-05 21:28:01 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#391) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]>

…d-exclude-prefixes-k8s@main (#12097) PR link: networkservicemesh/cmd-exclude-prefixes-k8s#303 Commit: 023ef9d Author: Network Service Mesh Bot Date: 2024-08-05 21:27:43 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#303) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-forwarder-sriov@main (#12083) PR link: networkservicemesh/cmd-forwarder-sriov#751 Commit: 206fb8b Author: Network Service Mesh Bot Date: 2024-08-05 21:27:44 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#751) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

…d-admission-webhook-k8s@main (#12134) PR link: networkservicemesh/cmd-admission-webhook-k8s#442 Commit: a8e4892 Author: Network Service Mesh Bot Date: 2024-08-05 21:27:36 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk-k8s@main (#442) PR link: networkservicemesh/sdk-k8s#513 Commit: 7c3c5af Author: Network Service Mesh Bot Date: 2024-08-05 21:24:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/sdk@main (#513) PR link: networkservicemesh/sdk#1643 Commit: bc1d964 Author: Nikita Skrynnik Date: 2024-08-01 20:19:08 +1100 Message: - Leak fixes (#1643) * update grpcfd (#1640) * fix monitor * fix CI * add unit tests + fix some errors * add unit tests * fix CI * cleanup --------- Signed-off-by: Denis Tingaikin <[email protected]> Signed-off-by: NikitaSkrynnik <[email protected]> Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>

This reverts commit bc1d964.

NikitaSkrynnik mentioned this pull request Jun 27, 2024

Controlplane part of forwarder-vpp leaks networkservicemesh/cmd-forwarder-vpp#1129

Open

10 tasks

NikitaSkrynnik force-pushed the leak-fixes branch from 44902a1 to bb57102 Compare June 27, 2024 11:37

update grpcfd (networkservicemesh#1640)

ce7b9a8

Signed-off-by: Denis Tingaikin <[email protected]>

NikitaSkrynnik force-pushed the leak-fixes branch from bb57102 to ce7b9a8 Compare June 27, 2024 14:58

denis-tingaikin reviewed Jul 1, 2024

View reviewed changes

NikitaSkrynnik force-pushed the leak-fixes branch from a3d6c41 to 854ca2c Compare July 1, 2024 12:45

fix monitor

5c398dc

Signed-off-by: NikitaSkrynnik <[email protected]>

NikitaSkrynnik force-pushed the leak-fixes branch from 854ca2c to 5c398dc Compare July 1, 2024 12:47

fix CI

cee05f2

Signed-off-by: NikitaSkrynnik <[email protected]>

denis-tingaikin reviewed Jul 4, 2024

View reviewed changes

pkg/networkservice/common/monitor/client_filter.go Outdated Show resolved Hide resolved

NikitaSkrynnik added 2 commits July 4, 2024 12:56

add unit tests + fix some errors

8a22601

Signed-off-by: NikitaSkrynnik <[email protected]>

add unit tests

b756c07

Signed-off-by: NikitaSkrynnik <[email protected]>

NikitaSkrynnik force-pushed the leak-fixes branch from 043face to b756c07 Compare July 5, 2024 07:09

fix CI

93e4e4a

Signed-off-by: NikitaSkrynnik <[email protected]>

cleanup

9d3f6d3

Signed-off-by: NikitaSkrynnik <[email protected]>

NikitaSkrynnik marked this pull request as ready for review July 5, 2024 08:02

denis-tingaikin requested a review from Ex4amp1e July 26, 2024 10:10

denis-tingaikin approved these changes Aug 1, 2024

View reviewed changes

denis-tingaikin merged commit bc1d964 into networkservicemesh:main Aug 1, 2024
15 checks passed

nsmbot mentioned this pull request Aug 1, 2024

Update from update/networkservicemesh/cmd-forwarder-ovs networkservicemesh/deployments-k8s#12133

Merged

nsmbot mentioned this pull request Aug 6, 2024

Update from update/networkservicemesh/cmd-admission-webhook-k8s networkservicemesh/deployments-k8s#12134

Merged

nsmbot mentioned this pull request Aug 6, 2024

Update from update/networkservicemesh/cmd-forwarder-ovs networkservicemesh/deployments-k8s#12135

Merged

denis-tingaikin added a commit that referenced this pull request Sep 13, 2024

Revert "Leak fixes (#1643)"

61f1141

This reverts commit bc1d964.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leak fixes #1643

Leak fixes #1643

NikitaSkrynnik commented Jun 26, 2024 •

edited

Loading

denis-tingaikin left a comment •

edited

Loading

codecov bot commented Jul 5, 2024

Leak fixes #1643

Leak fixes #1643

Conversation

NikitaSkrynnik commented Jun 26, 2024 • edited Loading

Description

Issue link

How Has This Been Tested?

Types of changes

denis-tingaikin left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jul 5, 2024

Codecov Report

NikitaSkrynnik commented Jun 26, 2024 •

edited

Loading

denis-tingaikin left a comment •

edited

Loading