Fix event system in vl3 client #1598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NikitaSkrynnik <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
=======================================
Coverage ? 67.28%
=======================================
Files ? 262
Lines ? 12456
Branches ? 0
=======================================
Hits ? 8381
Misses ? 3552
Partials ? 523 ☔ View full report in Codecov by Sentry. |
Signed-off-by: NikitaSkrynnik <[email protected]>
Signed-off-by: NikitaSkrynnik <[email protected]>
| @@ -32,6 +32,39 @@ type IPAM struct { | |||
| ipPool *ippool.IPPool | |||
| excludedPrefixes map[string]struct{} | |||
| clientMask uint8 | |||
| subscriptions []chan<- struct{} | |||
There was a problem hiding this comment.
Suggested change
| subscriptions []chan<- struct{} | |
| subscriptions []func() |
| } | ||
|
|
||
| // Subscribe creates a subscription for receiving events about changed prefixes | ||
| func (p *IPAM) Subscribe(ch chan<- struct{}) { |
There was a problem hiding this comment.
Suggested change
| func (p *IPAM) Subscribe(ch chan<- struct{}) { | |
| func (p *IPAM) Subscribe(action unc()) context.CancelFunc { |
| @@ -142,6 +175,7 @@ func (p *IPAM) Reset(ctx context.Context, prefix string, excludePrefies []string | |||
| p.ipPool.ExcludeString(excludePrefix) | |||
| p.excludedPrefixes[excludePrefix] = struct{}{} | |||
| } | |||
| p.notify() | |||
There was a problem hiding this comment.
Suggested change
| p.notify() | |
| p.notify() // run each sunbscriber |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
networkservicemesh/cmd-nse-vl3-vpp#289
https://github.com/networkservicemesh/integration-k8s-kind/actions/runs/8377013129/job/22938067943?pr=995
How Has This Been Tested?
Types of changes