Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not use settings from the previous connection if the connection was reselected #1531

Merged
merged 1 commit into from
Nov 22, 2023
Merged

fix: Do not use settings from the previous connection if the connection was reselected #1531

merged 1 commit into from
Nov 22, 2023

Conversation

denis-tingaikin
Copy link
Member

Description

Issue link

Closes networkservicemesh/deployments-k8s#9888

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
resolve issue deployments-k8s#9888
e2682fa 
Signed-off-by: Denis Tingaikin <[email protected]>
@denis-tingaikin denis-tingaikin changed the title fix: Do not use settings from previous connection if connection was reselected fix: Do not use settings from the previous connection if the connection was reselected Oct 16, 2023
@denis-tingaikin denis-tingaikin marked this pull request as ready for review October 16, 2023 16:22
@glazychev-art glazychev-art merged commit cb5a6d2 into main Nov 22, 2023
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
45fa954 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8e867d8 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6c5c739 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c92477f 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0d22224 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ec36e03 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
db9ca77 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4f8703c 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
03f6b6f 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7ec8949 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
39824de 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6b049fb 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 22, 2023
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6e3245f 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 22, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
796ed4b 
…k@main

PR link: networkservicemesh/sdk#1531

Commit: cb5a6d2
Author: Denis Tingaikin
Date: 2023-11-22 14:10:07 +0300
Message:
  - resolve issue deployments-k8s#9888 (#1531)
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 22, 2023
Merged
This was referenced Nov 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
denis-tingaikin added a commit that referenced this pull request Nov 28, 2023
@denis-tingaikin
resolve issue deployments-k8s#9888 (#1531)
94963b1 
Signed-off-by: Denis Tingaikin <[email protected]>
denis-tingaikin added a commit that referenced this pull request Dec 12, 2023
@denis-tingaikin
resolve issue deployments-k8s#9888 (#1531)
915497b 
Signed-off-by: Denis Tingaikin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaSkrynnik NikitaSkrynnik NikitaSkrynnik approved these changes

@bellycat77 bellycat77 bellycat77 approved these changes

@d-uzlov d-uzlov d-uzlov approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

@dualBreath dualBreath dualBreath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Healing with two NSEs could keep previous IPContext values
6 participants
@denis-tingaikin @dualBreath @glazychev-art @d-uzlov @bellycat77 @NikitaSkrynnik