Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipv6 dns entries #1371

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fix ipv6 dns entries #1371

merged 1 commit into from
Nov 21, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Oct 13, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev [email protected]

Description

ip.To16() != nil doesn't mean that this is IPv6 address - https://github.com/golang/go/blob/master/src/net/ip.go#L226-L234
It can convert IPv4 to IPv6.

We can only rely on ip.To4()

Issue link

networkservicemesh/integration-k8s-aws#322

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix ipv6 dns entries
d7565c3 
Signed-off-by: Artem Glazychev <[email protected]>
@denis-tingaikin denis-tingaikin merged commit 1d79bf8 into networkservicemesh:main Nov 21, 2022
@denis-tingaikin denis-tingaikin mentioned this pull request Nov 21, 2022
Closed
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d179b3d 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ace86c4 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 21, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
24660c9 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 21, 2022
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2c73b3d 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
24de6a4 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 21, 2022
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2e8795f 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 21, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4972033 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 21, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
64d245f 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
16575dc 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 21, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f4b1f8f 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 21, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e516853 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this pull request Nov 21, 2022
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
29bbc35 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 21, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0a01d32 
…k@main

PR link: networkservicemesh/sdk#1371

Commit: 1d79bf8
Author: Artem Glazychev
Date: 2022-11-22 03:26:37 +0700
Message:
  - Fix ipv6 dns entries (#1371)
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 21, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin