-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix begin on refresh #1365
Merged
denis-tingaikin
merged 1 commit into
networkservicemesh:main
from
glazychev-art:fix_begin_refresh
Oct 12, 2022
Merged
Fix begin on refresh #1365
denis-tingaikin
merged 1 commit into
networkservicemesh:main
from
glazychev-art:fix_begin_refresh
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
fix_begin_refresh
branch
from
October 11, 2022 12:32
076a813
to
8f6f8ba
Compare
edwarnicke
approved these changes
Oct 11, 2022
denis-tingaikin
approved these changes
Oct 12, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 12, 2022
…k@main PR link: networkservicemesh/sdk#1365 Commit: 6c3f844 Author: Artem Glazychev Date: 2022-10-12 21:27:42 +0700 Message: - Fix begin on refresh (#1365) Signed-off-by: Artem Glazychev <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev [email protected]
Description
Steps to reproduce:
See -
network service endpoint {NAME} not found: all forwarders have failed
Why is this happening?
After restarting the remote Nsmgr, it reconnects to the remote Forwarder with the same
connID
, but with a different context values (this is needed forauthorize
chain element).begin
has a map that stores the eventFactory byconnID
. When the recreated Nsmgr reaches the Forwarder, we use the previous eventFactory with the old internal context.After that, all calls from
eventFactory
will fail. For example, nsmonitor will not work on forwarder. And it affects the healing.Issue link
#1357
How Has This Been Tested?
Types of changes