feat: Update discoverforwarder to latest api changes #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
improve-discover-forwarder
branch
3 times, most recently
from
6cd4493 to
9c1522b
Compare
Signed-off-by: denis-tingaikin <[email protected]>
denis-tingaikin
force-pushed
the
improve-discover-forwarder
branch
from
9c1522b to
07ececc
Compare
Signed-off-by: denis-tingaikin <[email protected]>
edwarnicke
reviewed
Nov 10, 2021
.golangci.yml
Outdated
| @@ -47,7 +47,7 @@ linters-settings: | |||
| - errors | |||
| packages-with-error-message: | |||
| # specify an error message to output when a blacklisted package is used | |||
| - errors: "Please use \"github.com/pkg/errors\" instead of \"errors\" in go imports" | |||
| - errors: "Please use \"github.com/pkg/errors\" instead of \"errors\" in go imports" | |||
There was a problem hiding this comment.
I'm curious, why the extra white space here?
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 10, 2021
…k@main PR link: networkservicemesh/sdk#1151 Commit: 2272de7 Author: Denis Tingaikin Date: 2021-11-10 23:03:17 +0300 Message: - feat: Update discoverforwarder to latest api changes (#1151) * update discoverforwarder to latest api changes Signed-off-by: denis-tingaikin <[email protected]> * fix yamllinter Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingaikin [email protected]
Description
Issue link
Requires for #1094
Requires for networkservicemesh/integration-k8s-kind#454
How Has This Been Tested?
Types of changes