Added fallthrough check in matching #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <[email protected]>
|
Please add also unit test to cover the use-case with |
Mixaster995
force-pushed
the
improvement/match_selection
branch
from
ee89adc to
3922e08
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
Mixaster995
force-pushed
the
improvement/match_selection
branch
from
3922e08 to
6892900
Compare
Mixaster995
force-pushed
the
improvement/match_selection
branch
from
ea5e530 to
0162ebc
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
Mixaster995
force-pushed
the
improvement/match_selection
branch
from
0162ebc to
38746af
Compare
Signed-off-by: Mikhail Avramenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko [email protected]
Description
Fix for match selector which enables continuation in case of absent nse candidates
Issue link
part of networkservicemesh/deployments-k8s#2007
blocked by networkservicemesh/api#106
How Has This Been Tested?
Types of changes