Limit interface name (#1022)

Signed-off-by: Artem Glazychev <[email protected]>
networkservicemesh · Jul 15, 2021 · 7f3f374 · 7f3f374
1 parent f36729d
commit 7f3f374
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/networkservice/common/mechanisms/kernel/client.go b/pkg/networkservice/common/mechanisms/kernel/client.go
@@ -56,7 +56,7 @@ func (k *kernelMechanismClient) Request(ctx context.Context, request *networkser
 			},
 		}
 		if k.interfaceName != "" {
-			mechanism.Parameters[kernel.InterfaceNameKey] = k.interfaceName
+			mechanism.Parameters[kernel.InterfaceNameKey] = limitName(k.interfaceName)
 		}
 		request.MechanismPreferences = append(request.GetMechanismPreferences(), mechanism)
 	}

diff --git a/pkg/networkservice/common/mechanisms/kernel/utils.go b/pkg/networkservice/common/mechanisms/kernel/utils.go
@@ -31,8 +31,12 @@ func GetNameFromConnection(conn *networkservice.Connection) string {
 		ns = ns[:nsMaxLength]
 	}
 	name := fmt.Sprintf("%s-%s", ns, conn.GetId())
+	return limitName(name)
+}
+
+func limitName(name string) string {
 	if len(name) > kernelmech.LinuxIfMaxLength {
-		name = name[:kernelmech.LinuxIfMaxLength]
+		return name[:kernelmech.LinuxIfMaxLength]
 	}
 	return name
 }