Fix running test for Linux on MacOS #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Peretyatko <[email protected]>
|
@denis-tingaikin, @NikitaSkrynnik please review |
denis-tingaikin
approved these changes
Aug 29, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Aug 29, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#739 Commit: db44fd0 Author: Alexander Peretyatko Date: 2023-08-29 18:41:10 +0700 Message: - Fix running test for Linux on MacOS (#739) Signed-off-by: Alexander Peretyatko <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Aug 29, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the error is trying to run a Linux test on macOS: https://github.com/networkservicemesh/sdk-vpp/actions/runs/6003228815/job/16281229610?pr=738
All sources refer to a Linux build, so this test cannot be run on macOS:
sdk-vpp/pkg/tools/proxy/proxy_connection.go
Line 19 in 0633e49
sdk-vpp/pkg/tools/proxy/proxy_listener.go
Line 19 in 0633e49
Related to a fixed running permission tests: networkservicemesh/.github#40
Fixed the same as in sdk-kernel: https://github.com/networkservicemesh/sdk-kernel/blob/main/pkg/kernel/tools/nshandle/ns_handle_linux_test.go