Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MTU adjustment in case of remote vlan mechanism #656

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

ljkiraly
Copy link
Contributor

@ljkiraly ljkiraly commented Nov 9, 2022

The MTU should be updated in connection context based on the host interface MTU in vpp instead of the sub-interface MTU

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly [email protected]

@ljkiraly ljkiraly marked this pull request as draft November 9, 2022 15:54
@ljkiraly ljkiraly requested a review from LionelJouin November 9, 2022 15:54
ljkiraly added a commit to Nordix/sdk-ovs that referenced this pull request Nov 10, 2022
The MTU should be updated in connection context based on the base interface MTU

Relates PR: networkservicemesh/sdk-vpp/pull/656

Signed-off-by: Laszlo Kiraly <[email protected]>
ljkiraly added a commit to Nordix/sdk-ovs that referenced this pull request Nov 10, 2022
The MTU should be updated in connection context based on the base interface MTU

Relates PR: networkservicemesh/sdk-vpp/pull/656

Signed-off-by: Laszlo Kiraly <[email protected]>
@ljkiraly ljkiraly marked this pull request as ready for review November 14, 2022 16:50
ljkiraly added a commit to Nordix/sdk-ovs that referenced this pull request Nov 15, 2022
The MTU should be updated in connection context based on the base interface MTU

Relates PR: networkservicemesh/sdk-vpp/pull/656

Signed-off-by: Laszlo Kiraly <[email protected]>
@ljkiraly ljkiraly requested a review from edwarnicke November 15, 2022 12:03
@edwarnicke
Copy link
Member

LGTM, but needs a rebase :)

The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
@edwarnicke edwarnicke merged commit 89baf2c into networkservicemesh:main Nov 19, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Nov 19, 2022
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <[email protected]>
Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit that referenced this pull request Apr 11, 2024
…k-kernel@main

PR link: networkservicemesh/sdk-kernel#656

Commit: 55c91b5
Author: Denis Tingaikin
Date: 2024-04-11 20:08:14 +0300
Message:
  - Merge pull request #656 from NikitaSkrynnik/update-deps-workflow
Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants