qfix: Prevent potential leaks of loopback ifaces on request error #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis-tingaikin <[email protected]>
denis-tingaikin
commented
Apr 12, 2022
| @@ -56,7 +56,7 @@ func (l *loopbackClient) Request(ctx context.Context, request *networkservice.Ne | |||
| if err := createLoopback(ctx, l.vppConn, networkService, l.loopbacks, metadata.IsClient(l)); err != nil { | |||
| return nil, err | |||
| } | |||
| postponeCtxFunc := postpone.Context(ctx) | |||
| postponeCtxFunc := postpone.ContextWithValues(ctx) | |||
There was a problem hiding this comment.
Loopback depends on metadata. So we should use context with values.
denis-tingaikin
commented
Apr 12, 2022
| @@ -53,9 +54,13 @@ func (l *loopbackServer) Request(ctx context.Context, request *networkservice.Ne | |||
| if err := createLoopback(ctx, l.vppConn, networkService, l.loopbacks, metadata.IsClient(l)); err != nil { | |||
| return nil, err | |||
| } | |||
| postponeCtxFunc := postpone.ContextWithValues(ctx) | |||
|
|
|||
There was a problem hiding this comment.
server side doesn't care about context expiration on getting error => added postponeCtxFunc.
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
This was referenced Apr 12, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Apr 12, 2022
…k-vpp@main PR link: networkservicemesh/sdk-vpp#556 Commit: 8ecddc7 Author: Denis Tingaikin Date: 2022-04-13 00:09:01 +0300 Message: - fix potential leaks of loopback chain element (#556) Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
that referenced
this pull request
Jan 23, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#556 Commit: d38c463 Author: Denis Tingaikin Date: 2023-01-23 11:32:16 +0300 Message: - Merge pull request #556 from wazsone/ci/fix-depricated Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingaikin [email protected]