-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse so that 'server' things happen before the 'connect' for client. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, the rule is: 1. Provide information on the outbound direction of the call chain 2. Take action on the return path of the call chain. Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/cmd-forwarder-vpp
that referenced
this pull request
Apr 11, 2021
Signed-off-by: Ed Warnicke <[email protected]>
fkautz
approved these changes
Apr 11, 2021
edwarnicke
added a commit
to edwarnicke/cmd-forwarder-vpp
that referenced
this pull request
Apr 12, 2021
Signed-off-by: Ed Warnicke <[email protected]>
fkautz
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Apr 12, 2021
Signed-off-by: Ed Warnicke <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Apr 12, 2021
…cmd-forwarder-vpp@master networkservicemesh/cmd-forwarder-vpp# networkservicemesh/cmd-forwarder-vpp PR link: https://github.com/networkservicemesh/cmd-forwarder-vpp/pull/ networkservicemesh/cmd-forwarder-vpp commit message: commit 1a4ec434cf905a3ec4cdcce5e933b59346a01340 Author: Ed Warnicke <[email protected]> Date: Sun Apr 11 21:26:36 2021 -0500 Fixes for networkservicemesh/sdk-vpp#156 (#124) Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
edwarnicke
added a commit
to edwarnicke/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 13, 2021
Changes to reverse server chain elements to make decisions on the outbound direction of the call and take action on the return direction of the call in sdk-vpp: networkservicemesh/sdk-vpp#156 Required adaptation (another example is in cmd-forwarder-vpp: networkservicemesh/cmd-forwarder-vpp#124 ) Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke
added a commit
to edwarnicke/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 13, 2021
Changes to reverse server chain elements to make decisions on the outbound direction of the call and take action on the return direction of the call in sdk-vpp: networkservicemesh/sdk-vpp#156 Required adaptation (another example is in cmd-forwarder-vpp: networkservicemesh/cmd-forwarder-vpp#124 ) Signed-off-by: Ed Warnicke <[email protected]>
fkautz
added a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Apr 13, 2021
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Apr 13, 2021
…cmd-nse-icmp-responder-vpp@master networkservicemesh/cmd-nse-icmp-responder-vpp# networkservicemesh/cmd-nse-icmp-responder-vpp PR link: https://github.com/networkservicemesh/cmd-nse-icmp-responder-vpp/pull/ networkservicemesh/cmd-nse-icmp-responder-vpp commit message: commit c758c0491f5c9ca72aa6ac46c5bf2e87e60586ef Author: Frederick F. Kautz IV <[email protected]> Date: Tue Apr 13 16:29:55 2021 -0700 Merge pull request #65 from edwarnicke/reverse Fixes for networkservicemesh/sdk-vpp#156 Signed-off-by: NSMBot <[email protected]>
edwarnicke
added a commit
to edwarnicke/sdk
that referenced
this pull request
Apr 17, 2021
Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]>
fkautz
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
Apr 17, 2021
Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. #156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Apr 17, 2021
…k@main networkservicemesh/sdk# networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/ networkservicemesh/sdk commit message: commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7 Author: Ed Warnicke <[email protected]> Date: Sat Apr 17 18:23:27 2021 -0500 Retire supported chain element (#843) Since sdk-vpp has been reworked to shift server chain elements before connect chain elements supported is neither used nor needed. networkservicemesh/sdk-vpp#156 Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
This was referenced Apr 17, 2021
This was referenced Apr 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.