Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse so that 'server' things happen before the 'connect' for client. #156

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

edwarnicke
Copy link
Member

No description provided.

Basically, the rule is:

1.  Provide information on the outbound direction of the call chain
2.  Take action on the return path of the call chain.

Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke added a commit to edwarnicke/cmd-forwarder-vpp that referenced this pull request Apr 11, 2021
@fkautz fkautz merged commit 53cc4f6 into networkservicemesh:main Apr 11, 2021
edwarnicke added a commit to edwarnicke/cmd-forwarder-vpp that referenced this pull request Apr 12, 2021
fkautz pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Apr 12, 2021
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Apr 12, 2021
…cmd-forwarder-vpp@master networkservicemesh/cmd-forwarder-vpp#

networkservicemesh/cmd-forwarder-vpp PR link: https://github.com/networkservicemesh/cmd-forwarder-vpp/pull/

networkservicemesh/cmd-forwarder-vpp commit message:
commit 1a4ec434cf905a3ec4cdcce5e933b59346a01340
Author: Ed Warnicke <[email protected]>
Date:   Sun Apr 11 21:26:36 2021 -0500

    Fixes for networkservicemesh/sdk-vpp#156 (#124)

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
edwarnicke added a commit to edwarnicke/cmd-nse-icmp-responder-vpp that referenced this pull request Apr 13, 2021
Changes to reverse server chain elements to make decisions
on the outbound direction of the call and take action on the return
direction of the call in sdk-vpp:

networkservicemesh/sdk-vpp#156

Required adaptation (another example is in cmd-forwarder-vpp:
networkservicemesh/cmd-forwarder-vpp#124
)

Signed-off-by: Ed Warnicke <[email protected]>
edwarnicke added a commit to edwarnicke/cmd-nse-icmp-responder-vpp that referenced this pull request Apr 13, 2021
Changes to reverse server chain elements to make decisions
on the outbound direction of the call and take action on the return
direction of the call in sdk-vpp:

networkservicemesh/sdk-vpp#156

Required adaptation (another example is in cmd-forwarder-vpp:
networkservicemesh/cmd-forwarder-vpp#124
)

Signed-off-by: Ed Warnicke <[email protected]>
fkautz added a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Apr 13, 2021
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Apr 13, 2021
…cmd-nse-icmp-responder-vpp@master networkservicemesh/cmd-nse-icmp-responder-vpp#

networkservicemesh/cmd-nse-icmp-responder-vpp PR link: https://github.com/networkservicemesh/cmd-nse-icmp-responder-vpp/pull/

networkservicemesh/cmd-nse-icmp-responder-vpp commit message:
commit c758c0491f5c9ca72aa6ac46c5bf2e87e60586ef
Author: Frederick F. Kautz IV <[email protected]>
Date:   Tue Apr 13 16:29:55 2021 -0700

    Merge pull request #65 from edwarnicke/reverse

    Fixes for networkservicemesh/sdk-vpp#156

Signed-off-by: NSMBot <[email protected]>
edwarnicke added a commit to edwarnicke/sdk that referenced this pull request Apr 17, 2021
Since sdk-vpp has been reworked to shift server chain elements
before connect chain elements supported is neither used nor needed.

networkservicemesh/sdk-vpp#156

Signed-off-by: Ed Warnicke <[email protected]>
fkautz pushed a commit to networkservicemesh/sdk that referenced this pull request Apr 17, 2021
Since sdk-vpp has been reworked to shift server chain elements
before connect chain elements supported is neither used nor needed.

networkservicemesh/sdk-vpp#156

Signed-off-by: Ed Warnicke <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    #156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Apr 17, 2021
…k@main networkservicemesh/sdk#

networkservicemesh/sdk PR link: https://github.com/networkservicemesh/sdk/pull/

networkservicemesh/sdk commit message:
commit d30bde378a8bf3af5c6136f0ee696c7c41a6bbc7
Author: Ed Warnicke <[email protected]>
Date:   Sat Apr 17 18:23:27 2021 -0500

    Retire supported chain element (#843)

    Since sdk-vpp has been reworked to shift server chain elements
    before connect chain elements supported is neither used nor needed.

    networkservicemesh/sdk-vpp#156

    Signed-off-by: Ed Warnicke <[email protected]>

Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants