Refactor chains/forwarder to use Options pattern #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bszirtes
force-pushed
the
refactor-chains-options-pattern
branch
3 times, most recently
from
4249486 to
c3beed8
Compare
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 15, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
force-pushed
the
refactor-chains-options-pattern
branch
from
c3beed8 to
2183c3f
Compare
9 tasks
denis-tingaikin
approved these changes
Apr 16, 2024
Yes, I did, using the changes that I made in the forwarder-ovs too (networkservicemesh/cmd-forwarder-ovs#363). |
|
I'm fine with merging this. @ljkiraly Do you have any comments on the PR? |
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-ovs
that referenced
this pull request
Apr 18, 2024
…k-ovs@main PR link: networkservicemesh/sdk-ovs#320 Commit: d21bcac Author: Denis Tingaikin Date: 2024-04-18 18:26:53 +0300 Message: - Merge pull request #320 from Nordix/refactor-chains-options-pattern Signed-off-by: NSMBot <[email protected]>
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 19, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 19, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 22, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 22, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 22, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
bszirtes
added a commit
to Nordix/cmd-forwarder-ovs
that referenced
this pull request
Apr 22, 2024
Depends on: networkservicemesh/sdk-ovs#320 Signed-off-by: Botond Szirtes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring chains/forwarder using the Functional Options Pattern, just as it has been implemented in the sdk.
Issue link
#319
How Has This Been Tested?
Types of changes