-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix interface cleanup #275
Conversation
Move an orphan nsm interface to host namespace and delete it. Related issue: networkservicemesh/deployments-k8s#9778 Related PR: networkservicemesh/sdk-ovs#275 Signed-off-by: Laszlo Kiraly <[email protected]>
Move an orphan nsm interface to host namespace and delete it. Related issue: networkservicemesh/deployments-k8s#9778 Related PR: networkservicemesh/sdk-ovs#275 Signed-off-by: Laszlo Kiraly <[email protected]>
Related issue: networkservicemesh/deployments-k8s#9778 Signed-off-by: Laszlo Kiraly <[email protected]>
Move an orphan nsm interface to host namespace and delete it. Related issue: networkservicemesh/deployments-k8s#9778 Related PR: networkservicemesh/sdk-ovs#275 Signed-off-by: Laszlo Kiraly <[email protected]>
Move an orphan nsm interface to host namespace and delete it. Related issue: networkservicemesh/deployments-k8s#9778 Related PR: networkservicemesh/sdk-ovs#275 Signed-off-by: Laszlo Kiraly <[email protected]>
@ljkiraly
But we can change it to
(same for server, I think) |
@ljkiraly I think it can be merged. Would you like to resolve comment #275 (comment) before merging? |
@denis-tingaikin Yes, please do not merge this yet. The comment is valid and I am to test with the proposed modification. |
@ljkiraly Sure, all good |
This is also fixed in sdk-kernel by correction: networkservicemesh/sdk-kernel#618 |
Description
The vfConfig structure deleted too early and the inject module can not find the information to delete the interface.
Debug printouts added in cases when interface is added or deleted.
Issue link
Related to: networkservicemesh/deployments-k8s#9778
How Has This Been Tested?
Types of changes