-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go to 1.23.1 #688
Merged
denis-tingaikin
merged 9 commits into
networkservicemesh:main
from
Ex4amp1e:update-go-1.23.1
Nov 19, 2024
Merged
Update go to 1.23.1 #688
denis-tingaikin
merged 9 commits into
networkservicemesh:main
from
Ex4amp1e:update-go-1.23.1
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Byrgazov <[email protected]>
Ex4amp1e
force-pushed
the
update-go-1.23.1
branch
from
October 16, 2024 08:20
0fd6124
to
64d2e7d
Compare
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: Vladislav Byrgazov <[email protected]>
Ex4amp1e
force-pushed
the
update-go-1.23.1
branch
from
November 12, 2024 08:48
b9a85d0
to
c794195
Compare
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: Vladislav Byrgazov <[email protected]>
@@ -148,19 +134,14 @@ linters: | |||
- gosimple | |||
- govet | |||
- ineffassign | |||
- interfacer | |||
# - lll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be enabled, see at networkservicemesh/api#177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Vladislav Byrgazov <[email protected]>
Ex4amp1e
force-pushed
the
update-go-1.23.1
branch
from
November 18, 2024 07:15
f975cbc
to
8d64488
Compare
Signed-off-by: Vladislav Byrgazov <[email protected]>
Ex4amp1e
force-pushed
the
update-go-1.23.1
branch
from
November 19, 2024 11:05
54ccce2
to
659d1de
Compare
Signed-off-by: Vladislav Byrgazov <[email protected]>
denis-tingaikin
approved these changes
Nov 19, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Nov 19, 2024
…k-kernel@main PR link: networkservicemesh/sdk-kernel#688 Commit: 74f2bf2 Author: Denis Tingaikin Date: 2024-11-19 09:00:44 -0500 Message: - Merge pull request #688 from Ex4amp1e/update-go-1.23.1 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Nov 19, 2024
…k-kernel@main PR link: networkservicemesh/sdk-kernel#688 Commit: 74f2bf2 Author: Denis Tingaikin Date: 2024-11-19 09:00:44 -0500 Message: - Merge pull request #688 from Ex4amp1e/update-go-1.23.1 Signed-off-by: NSMBot <[email protected]>
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Nov 19, 2024
…k-kernel@main PR link: networkservicemesh/sdk-kernel#688 Commit: 74f2bf2 Author: Denis Tingaikin Date: 2024-11-19 09:00:44 -0500 Message: - Merge pull request #688 from Ex4amp1e/update-go-1.23.1 Signed-off-by: NSMBot <[email protected]>
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#12294