vL3 load balancer example #9830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
lb_example
branch
from
2cd2901 to
e3101ba
Compare
glazychev-art
requested review from
denis-tingaikin,
NikitaSkrynnik and
d-uzlov
NikitaSkrynnik
approved these changes
Sep 20, 2023
d-uzlov
reviewed
Sep 22, 2023
Comment on lines
+15
to
+16
| - name: POD_NAME | ||
| value: "finance" |
There was a problem hiding this comment.
Why do we need a hardcoded pod name env here?
There was a problem hiding this comment.
We use POD_NAME as DNS name in vl3 examples
There was a problem hiding this comment.
I think it's worth mentioning in the readme file or adding a comment in the yaml file.
So that if someone wants to replicate vl3-lb setup it's clear what they should change.
I think, ideally there should be a different solution.
Each pod gets <pod-name>.vl3-domain address, and additionally some pods may get more DNS addresses.
Signed-off-by: Artem Glazychev <[email protected]>
glazychev-art
force-pushed
the
lb_example
branch
from
e3101ba to
40af724
Compare
denis-tingaikin
approved these changes
Sep 26, 2023
nsmbot
pushed a commit
to networkservicemesh/integration-tests
that referenced
this pull request
Sep 26, 2023
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#9830 Commit: 876dd11 Author: Network Service Mesh Bot Date: 2023-09-25 23:30:08 -0500 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue link
#9210
How Has This Been Tested?
Types of changes