Update from update/networkservicemesh/sdk #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@master networkservicemesh/sdk#446 networkservicemesh/sdk PR link: networkservicemesh/sdk#446 networkservicemesh/sdk commit message: commit 1be3f50d7da793ed1ff063c88e26e9c94bdfd44c Author: Ed Warnicke <[email protected]> Date: Fri Aug 21 01:55:31 2020 -0500 Encapsulating choices of context and dial options in a library is an anti-pattern. (#446) That should be driven from top level. Lets not do that here. Signed-off-by: Ed Warnicke <[email protected]> Signed-off-by: NSMBot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit a1f974e