Update from update/networkservicemesh/sdk #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k@main PR link: networkservicemesh/sdk#1072 Commit: 2e38282 Author: Ed Warnicke Date: 2021-08-31 03:56:01 -0500 Message: - Introducing the begin chain element (#1072) * Introducing the begin chain element Please read pkg/networkservice/common/begin/doc.go for extensive documentation. Signed-off-by: Ed Warnicke <[email protected]> * Update pkg/networkservice/common/begin/event_factory.go Signed-off-by: Ed Warnicke <[email protected]> Co-authored-by: Vladimir Popov <[email protected]> Signed-off-by: Ed Warnicke <[email protected]> * Update pkg/networkservice/common/begin/event_factory.go Signed-off-by: Ed Warnicke <[email protected]> Co-authored-by: Vladimir Popov <[email protected]> * Make metadata access functions private for refresh and timeout Signed-off-by: Ed Warnicke <[email protected]> * Simplify refresh/timeout cancel handling In response to comment: networkservicemesh/sdk#1072 (comment) Signed-off-by: Ed Warnicke <[email protected]> * Simplification in response to networkservicemesh/sdk#1072 (comment) Signed-off-by: Ed Warnicke <[email protected]> * Change in response to comment networkservicemesh/sdk#1072 (comment) Signed-off-by: Ed Warnicke <[email protected]> * Update pkg/networkservice/common/begin/event_factory.go Signed-off-by: Ed Warnicke <[email protected]> Co-authored-by: Denis Tingaikin <[email protected]> Signed-off-by: Ed Warnicke <[email protected]> * Improve logging in response to networkservicemesh/sdk#1072 (comment) Signed-off-by: Ed Warnicke <[email protected]> Co-authored-by: Vladimir Popov <[email protected]> Signed-off-by: NSMBot <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go.mod and go.sum to latest version from networkservicemesh/sdk@main
PR link: networkservicemesh/sdk#1072
Commit: 2e38282
Author: Ed Warnicke
Date: 2021-08-31 03:56:01 -0500
Message:
Please read pkg/networkservice/common/begin/doc.go
for extensive documentation.
Signed-off-by: Ed Warnicke [email protected]
Signed-off-by: Ed Warnicke [email protected]
Co-authored-by: Vladimir Popov [email protected]
Signed-off-by: Ed Warnicke [email protected]
Signed-off-by: Ed Warnicke [email protected]
Co-authored-by: Vladimir Popov [email protected]
Signed-off-by: Ed Warnicke [email protected]
In response to comment: Introducing the begin chain element sdk#1072 discussion_r697185038
Signed-off-by: Ed Warnicke [email protected]
Signed-off-by: Ed Warnicke [email protected]
Signed-off-by: Ed Warnicke [email protected]
Signed-off-by: Ed Warnicke [email protected]
Co-authored-by: Denis Tingaikin [email protected]
Signed-off-by: Ed Warnicke [email protected]
Signed-off-by: Ed Warnicke [email protected]
Co-authored-by: Vladimir Popov [email protected]