feat: implement initial version of cmd-nse-vl3-vpp #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <[email protected]>
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: Denis Tingaikin <[email protected]>
Signed-off-by: denis-tingaikin <[email protected]>
edwarnicke
reviewed
Mar 21, 2022
main.go
Outdated
|
|
||
| // Config holds configuration parameters from environment variables | ||
| type Config struct { | ||
| Name string `default:"icmp-server" desc:"Name of ICMP Server"` |
There was a problem hiding this comment.
Why is this called icmp-server?
edwarnicke
reviewed
Mar 21, 2022
main.go
Outdated
| ListenOn string `default:"listen.on.sock" desc:"listen on socket" split_words:"true"` | ||
| ConnectTo url.URL `default:"unix:///var/lib/networkservicemesh/nsm.io.sock" desc:"url to connect to" split_words:"true"` | ||
| MaxTokenLifetime time.Duration `default:"10m" desc:"maximum lifetime of tokens" split_words:"true"` | ||
| ServiceNames []string `default:"icmp-responder" desc:"Name of providing service" split_words:"true"` |
There was a problem hiding this comment.
Why does this default to I map server?
edwarnicke
reviewed
Mar 21, 2022
main.go
Outdated
| ConnectTo url.URL `default:"unix:///var/lib/networkservicemesh/nsm.io.sock" desc:"url to connect to" split_words:"true"` | ||
| MaxTokenLifetime time.Duration `default:"10m" desc:"maximum lifetime of tokens" split_words:"true"` | ||
| ServiceNames []string `default:"icmp-responder" desc:"Name of providing service" split_words:"true"` | ||
| Payload string `default:"IP" desc:"Name of provided service payload" split_words:"true"` |
There was a problem hiding this comment.
This should always be IP for vL3
Signed-off-by: denis-tingaikin <[email protected]>
nsmbot
pushed a commit
that referenced
this pull request
Jun 26, 2023
…vpp@main PR link: https://github.com/networkservicemesh/govpp/pull/ Commit: fc47696 Author: Denis Tingaikin Date: 2023-06-26 12:28:21 +0300 Message: - Merge pull request #4 from glazychev-art/generate Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1
Closes #2
Closes #3