Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cmd-nse-icmp-responder issues #7

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fix cmd-nse-icmp-responder issues #7

merged 2 commits into from
Nov 9, 2020

Conversation

denis-tingaikin
Copy link
Member

Motivation

This PR fixes a couple of issues that have been found during integration testing.

  1. Added docker cache.
  2. Fixed issue with NS registration.
  3. Fixed issue with NSE registration.
  4. Added grpc option with WaitFor to prevent container restarting.
  5. Added docker testing.
  6. Updated docker file.

@denis-tingaikin
Copy link
Member Author

Depends on networkservicemesh/cmd-template#34

@haiodo
Copy link
Contributor

haiodo commented Nov 9, 2020

@denis-tingajkin please rebase.

@denis-tingaikin
Fix issues and add docker cache
6f48489 
Signed-off-by: Denis Tingajkin <[email protected]>
@denis-tingaikin
fix linter issues
25c833e 
Signed-off-by: denis-tingajkin <[email protected]>
@haiodo haiodo merged commit 4f63908 into networkservicemesh:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiodo haiodo haiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @haiodo