Remove duplicated IPAM code #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruslan Bayandinov <[email protected]>
wazsone
force-pushed
the
feature/remove-duplicated-ipam-code
branch
from
0ba5f8a to
6d6abab
Compare
main.go
Outdated
| @@ -200,7 +198,7 @@ func main() { | |||
| log.FromContext(ctx).Infof("executing phase 3: creating icmp server ipam") | |||
| // ******************************************************************************** | |||
|
|
|||
| ipamChain := getIPAMChain(config.CidrPrefix) | |||
| ipamChain := groupipam.NewServer(config.CidrPrefix) | |||
There was a problem hiding this comment.
@denis-tingaikin Done
Signed-off-by: Ruslan Bayandinov <[email protected]>
denis-tingaikin
approved these changes
Jan 26, 2023
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Jan 26, 2023
…d-nse-icmp-responder@main PR link: networkservicemesh/cmd-nse-icmp-responder#500 Commit: 02f6c85 Author: Denis Tingaikin Date: 2023-01-26 10:50:55 +0300 Message: - Merge pull request #500 from wazsone/feature/remove-duplicated-ipam-code Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to networkservicemesh/sdk#1409