Fix: Close() is called with canceled context #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <[email protected]>
denis-tingaikin
approved these changes
May 17, 2021
| @@ -207,7 +207,7 @@ func main() { | |||
| } | |||
|
|
|||
| defer func() { | |||
| closeCtx, cancel := context.WithTimeout(ctx, config.RequestTimeout) | |||
| closeCtx, cancel := context.WithTimeout(context.Background(), config.RequestTimeout) | |||
There was a problem hiding this comment.
@glazychev-art Should we alo put here context with logger?
nsmbot
pushed a commit
that referenced
this pull request
Jun 29, 2023
This PR syncs files with https://github.com/networkservicemesh/cmd-template Revision: https://github.com/networkservicemesh/cmd-template/commits/c0ccc3bd02120b1c3d8391bc588016a714cf1a74 commit c0ccc3bd02120b1c3d8391bc588016a714cf1a74 Author: Lionel Jouin <[email protected]> Date: Thu Jun 29 21:09:40 2023 +0200 Update to go 1.20 (#118) Signed-off-by: Lionel Jouin <[email protected]> Signed-off-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#954
Signed-off-by: Artem Glazychev [email protected]