Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all tests to separate testing pkg #17

Closed
denis-tingaikin opened this issue Aug 11, 2020 · 2 comments
Closed

Move all tests to separate testing pkg #17

denis-tingaikin opened this issue Aug 11, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@denis-tingaikin
Copy link
Member

Motivation

We are not using white-box testing in newly styled NSM repositories. So then we should move all tests to separate pkgs and make sure that we are not testing private states

https://github.com/networkservicemesh/cmd-forwarder-sriov/blob/master/local/sdk-sriov/pkg/k8s/manager_test.go#L17
@denis-tingaikin denis-tingaikin changed the title Move all tests to testing package Move all tests to separate testing pck Aug 11, 2020
@denis-tingaikin denis-tingaikin changed the title Move all tests to separate testing pck Move all tests to separate testing pkg Aug 11, 2020
@denis-tingaikin denis-tingaikin added the bug Something isn't working label Aug 11, 2020
nsmbot pushed a commit that referenced this issue Jan 15, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4c2ca92 
…k-k8s@master networkservicemesh/sdk-k8s#17

networkservicemesh/sdk-k8s PR link: networkservicemesh/sdk-k8s#17

networkservicemesh/sdk-k8s commit message:
commit db696f8d7ba35b32de3fd6152aafadcf8d8820f7
Author: Andrey Sobolev <[email protected]>
Date:   Fri Jan 15 16:08:03 2021 +0700

    Merge pull request #17 from denis-tingaikin/correctly-update-entry-in-etcd

Signed-off-by: NSMBot <[email protected]>
@nsmbot nsmbot mentioned this issue Jan 15, 2021
Merged
@Bolodya1997
Copy link

Bolodya1997 commented Jan 18, 2021 •
edited
Loading

Fixed in #18, networkservicemesh/sdk-k8s#9.

@denis-tingaikin
Copy link
Member Author

@Bolodya1997 Nice! Let's attach a link to PR and this one can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Bolodya1997 @denis-tingaikin