Update go to 1.23 #431
Merged
Update go to 1.23 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 18, 2024 10:15
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: Vladislav Byrgazov <[email protected]>
Signed-off-by: Vladislav Byrgazov <[email protected]>
.github/workflows/ci.yaml
Outdated
| with: | ||
| go-version: 1.20.5 | ||
| go-version: 1.23.1 |
There was a problem hiding this comment.
Suggested change
| go-version: 1.23.1 | |
| go-version: 1.23.3 |
.github/workflows/ci.yaml
Outdated
| with: | ||
| go-version: 1.20.5 | ||
| go-version: 1.23.1 |
There was a problem hiding this comment.
Suggested change
| go-version: 1.23.1 | |
| go-version: 1.23.3 |
.golangci.yml
Outdated
Comment on lines
151
to
152
| - gocritic | ||
| - revive |
There was a problem hiding this comment.
Is it possible to disable just certain issues and keep these linters working with main.go?
There was a problem hiding this comment.
Sure, investigated more, we had collision of gocritic and govet linter about shadowing 'err' variables and as i got - this is convention to re-assign 'err', so applied gocritic fix and excluded govet 'err' shadowing
Signed-off-by: Vladislav Byrgazov <[email protected]>
denis-tingaikin
approved these changes
Nov 21, 2024
nsmbot
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 21, 2024
…d-forwarder-ovs@main PR link: networkservicemesh/cmd-forwarder-ovs#431 Commit: 05f86ff Author: Denis Tingaikin Date: 2024-11-21 10:01:53 +0000 Message: - Merge pull request #431 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <[email protected]>
denis-tingaikin
pushed a commit
to networkservicemesh/deployments-k8s
that referenced
this pull request
Nov 22, 2024
…d-forwarder-ovs@main (#12555) PR link: networkservicemesh/cmd-forwarder-ovs#431 Commit: 05f86ff Author: Denis Tingaikin Date: 2024-11-21 10:01:53 +0000 Message: - Merge pull request #431 from Ex4amp1e/update-go-1.23 Signed-off-by: NSMBot <[email protected]> Co-authored-by: NSMBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/deployments-k8s#12294