Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #319 environment variables cannot overwrite config values if it… #320

Merged
merged 2 commits into from
Oct 14, 2023
Merged

fixes #319 environment variables cannot overwrite config values if it… #320

merged 2 commits into from
Oct 14, 2023

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Oct 13, 2023

… is not string type

@stevehu stevehu requested a review from DiogoFKT October 13, 2023 13:57
DiogoFKT
DiogoFKT reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@DiogoFKT DiogoFKT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks fine - assuming parseBoolean should accept anything other than true (case insensitive) as false

@stevehu
Copy link
Contributor Author

stevehu commented Oct 13, 2023

In Java, the default is false for Boolean type. So only "true" represent true, and all other string will be false.

@stevehu stevehu merged commit 83b4e21 into master Oct 14, 2023
@stevehu stevehu deleted the issue319 branch October 14, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiogoFKT DiogoFKT DiogoFKT left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehu @DiogoFKT