Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #278 overwrite the basePath from handler.yml if it is not null #280

Merged
merged 1 commit into from
Jan 26, 2023
Merged

fixes #278 overwrite the basePath from handler.yml if it is not null #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions openapi-meta/src/main/java/com/networknt/openapi/OpenApiHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ public OpenApiHandler(OpenApiHandlerConfig cfg) {

helper = new OpenApiHelper(Config.getInstance().getMapper().writeValueAsString(openapi));

// overwrite the helper.basePath it cannot be derived from the openapi.yaml from the handler.yml
if (helper.basePath.isEmpty() && handlerConfig != null) {
// overwrite the helper.basePath if it cannot be derived from the openapi.yaml from the handler.yml
// if the basePath is not null. The default value if openapi.yml doesn't have basePath is "".
if (helper.basePath.isEmpty() && handlerConfig != null && handlerConfig.getBasePath() != null) {
helper.setBasePath(handlerConfig.getBasePath());
}

} catch (JsonProcessingException e) {
logger.error("merge specification failed");
throw new RuntimeException("merge specification failed");
Expand Down