-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #117 #118
fixes #117 #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChenYan71 : there is a second problem here, which IO was looking into fixing today. discussed it with @stevehu yesterday:
- the RequestValidator "is a" MiddlewareHandler, which in turn is a LightHttpHandler.
Setting the status code only, without calling the LightHttpHandler.setExchangeStatus(), will preclude us from saving the error for auditing purposes.
Ex.:
ValidatorHandler - l.80 - setExchangeStatus(exchange, ...);
is preferable.
At this time, in case of an OpenAPI validation failure, my client can't audit the failure.
Do you wish to change that as well?
@ddobrin I will take a look |
@ChenYan71 @ddobrin Do you think we should call the validateRequestBody if the contentType is null? I am thinking that we only need to validate if the header is application/json only; however, there might be the case that the user forgets to put the contentType header and we want to catch the error with the validation. |
No description provided.