Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev container changes for easier ROM uploading from the docker container to the SC64 #1

Conversation

Polprzewodnikowy
Copy link

Description

I've made some changes to deployment and build process to simplify loading built ROM from the inside of docker container.
This method involves running sc64deployer tool (https://github.com/Polprzewodnikowy/SummerCart64/releases/tag/v2.14.0) on host machine in server mode. Docker container uses the same tool but it connects to the server via TCP connection.

To use this deployment method:

  1. Run tool in server mode on host machine: sc64deployer server
  2. Run deployment script in docker machine: ./sc64deploy.sh (add -d argument to automatically start debug mode)

Libdragon submodule has been switched to unstable branch.

Dockerfile now uses standard Ubuntu image instead of dedicated N64 toolchain image.

Devcontainer config has been updated to build libdragon submodule after creating container.

GitHub actions can be updated to use devcontainer dockerfile.

Motivation and Context

Described above.

How Has This Been Tested?

On local environment with Windows OS host and SC64.

Screenshots

image

Types of changes

  • Improvement (non-breaking change that adds a new feature)
  • Bug fix (fixes an issue)
  • Breaking change (breaking change)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Polprzewodnikowy [email protected]

https://github.com/Polprzewodnikowy/SummerCart64

# License
GPL-3.0 license
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the license changed?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, I guess we are not actually using anything from it, so it falls into fair use.

.PHONY: clean

# run:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely should be used instead of (or call) sc64deploy.sh

.PHONY: clean

# run:

# test:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this commented out code should be removed as the aim would be to add unit tests where possible (given it is a placeholder before merge into the main repo)...

@@ -1,21 +0,0 @@
@echo off
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated rather than removed? or does a deploy now work well on a windows dev container?

@networkfusion
Copy link
Owner

It turns out that it is quite difficult to work between a branch that is a fork on a branch... but I have "fixed" the minify bits.
My main feeling at this point is the original libdragon docker should be improved (I already have a PR against it (see @rasky fork... , but will continue to integrate.

"source=n64flashcartmenu-bashhistory,target=/commandhistory,type=volume"
],
"postCreateCommand": "git submodule update && cd ./libdragon && ./build.sh",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that using git submodule update breaks this.

@networkfusion networkfusion changed the base branch from develop-menu to test-libdragon-unstable June 2, 2023 17:23
@networkfusion
Copy link
Owner

Completion of this PR is currently being carried out in https://github.com/networkfusion/N64FlashcartMenu/tree/test-libdragon-unstable . I have run into a few annoying things, like needing the sc64deployer not being compatible with debian slim (or probably other older linux versions for that matter), but nearly there.

@networkfusion networkfusion mentioned this pull request Jun 4, 2023
9 tasks
@networkfusion
Copy link
Owner

Closing as superseeded.

@networkfusion networkfusion deleted the new-deployer branch July 3, 2023 01:14
networkfusion pushed a commit that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants