-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev container changes for easier ROM uploading from the docker container to the SC64 #1
Conversation
https://github.com/Polprzewodnikowy/SummerCart64 | ||
|
||
# License | ||
GPL-3.0 license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the license changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, I guess we are not actually using anything from it, so it falls into fair use.
.PHONY: clean | ||
|
||
# run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surely should be used instead of (or call) sc64deploy.sh
.PHONY: clean | ||
|
||
# run: | ||
|
||
# test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this commented out code should be removed as the aim would be to add unit tests where possible (given it is a placeholder before merge into the main repo)...
@@ -1,21 +0,0 @@ | |||
@echo off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be updated rather than removed? or does a deploy now work well on a windows dev container?
65928fe
to
5485aef
Compare
It turns out that it is quite difficult to work between a branch that is a fork on a branch... but I have "fixed" the minify bits. |
"source=n64flashcartmenu-bashhistory,target=/commandhistory,type=volume" | ||
], | ||
"postCreateCommand": "git submodule update && cd ./libdragon && ./build.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that using git submodule update
breaks this.
Completion of this PR is currently being carried out in https://github.com/networkfusion/N64FlashcartMenu/tree/test-libdragon-unstable . I have run into a few annoying things, like needing the sc64deployer not being compatible with debian slim (or probably other older linux versions for that matter), but nearly there. |
Closing as superseeded. |
Description
I've made some changes to deployment and build process to simplify loading built ROM from the inside of docker container.
This method involves running
sc64deployer
tool (https://github.com/Polprzewodnikowy/SummerCart64/releases/tag/v2.14.0) on host machine in server mode. Docker container uses the same tool but it connects to the server via TCP connection.To use this deployment method:
sc64deployer server
./sc64deploy.sh
(add-d
argument to automatically start debug mode)Libdragon submodule has been switched to
unstable
branch.Dockerfile now uses standard Ubuntu image instead of dedicated N64 toolchain image.
Devcontainer config has been updated to build libdragon submodule after creating container.
GitHub actions can be updated to use devcontainer dockerfile.
Motivation and Context
Described above.
How Has This Been Tested?
On local environment with Windows OS host and SC64.
Screenshots
Types of changes
Checklist:
Signed-off-by: Polprzewodnikowy [email protected]