Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@heyheyhello
I fixed up a test,
api.hs
is used in some other packages and I think I would prefer to keep that uniform toapi.h
both of which could be overriden.svgJSX
is good but I'm not sure if it should be in the core.wouldn't this be a good utility function in the codebase of the user?
also is the
api.s
counting needed for nesting?I might need to change the api.hs function then
some lint errors