Add ability to get path stats #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested changes
Feb 26, 2024
...-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicheQuicConnectionPathStats.java
Outdated
Show resolved
Hide resolved
codec-native-quic/src/test/java/io/netty/incubator/codec/quic/QuicConnectionPathStatsTest.java
Outdated
Show resolved
Hide resolved
codec-classes-quic/src/main/java/io/netty/incubator/codec/quic/QuicheQuicChannel.java
Show resolved
Hide resolved
dries-c
added a commit
to NetherGamesMC/ProxyTransport
that referenced
this pull request
Mar 2, 2024
Check for return value
|
@dries-c thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Ability to get the RTT as requested in #678
Modification:
Add ability to get the path stats using quiche_conn_path_stats
Result:
The change adds the API to get the path stats, however I wasn't sure if I should include it in QuicheConnectionStats directly.