Skip to content

Commit

Permalink
Add TODO for later (#690)
Browse files Browse the repository at this point in the history
Motivation:

Let's add a TODO as we might want to implement QUIC parsing by ourselves
to reduce overhead in the future.

Modifications:

Add TODO

Result:

Keep track of possible future optimization
  • Loading branch information
normanmaurer authored Mar 11, 2024
1 parent 8b358cf commit fd48119
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@ public void parse(InetSocketAddress sender,
dcidLenBuffer.setInt(0, Quiche.QUICHE_MAX_CONN_ID_LEN);
tokenLenBuffer.setInt(0, maxTokenLength);

// TODO: Maybe we should implement this by ourself and just save the extra JNI call and memory copies.
// Parsing should be relative straight forward.
// See https://datatracker.ietf.org/doc/html/rfc9000#section-17
int res = Quiche.quiche_header_info(
Quiche.readerMemoryAddress(packet), packet.readableBytes(),
localConnectionIdLength,
Expand Down

0 comments on commit fd48119

Please sign in to comment.