TemplateFactory - variable template class (RFC)

[f3l1x]

Hi! I have and idea about TemplateFactory.

If you need to use your own Template class, you have to extend original TemplateFactory now.

What about this implementation?

protected $templateClass = 'Nette\Bridges\ApplicationLatte\Template';

public function createTemplate(UI\Control $control = NULL)
{
    $latte = $this->latteFactory->create();
    $template = new $this->templateClass($latte);
    $presenter = $control ? $control->getPresenter(FALSE) : NULL;
    //...
}

public function setTemplateClass($class) 
{
    $this->templateClass = $class;
}

What do you think? It makes TemplateFactory more flexible. You can setup your template implementation over NEON config.

services:
    latte.templateFactory:
        setup:
            - setTemplateClass(My\Custom\Template)

---

Thanks for feedback.

[TomasVotruba]

What is the use case for this?

[mrtnzlml]

@TomasVotruba For example this.

[TomasVotruba]

@mrtnzlml I see.

Coold you prepare PR for this with test?

[mrtnzlml]

I implemented it differently. But in fact it's quite similar to the @f3l1x solution. The only difference is that my solution doesn't use setter. And even though I believe that it's better without setter, I'm not sure about my implementation. Usage:

services:
    latte.templateFactory:
        arguments:
            templateClassName: App\CustomTemplateImplementation

Unfortunately Template cannot be service (or at least I don't know how to do it properly - and I tried).

[f3l1x]

Maybe it's little bit confusing name Template Factory, but I don't know better. What about new concept?

• LatteFactory - creates latte engine
• TemplateClassFactory - creates just Template class (depends on TemplateFactory)
• TemplateFactory - creates TemplateFactory via LatteFactory and TemplateClassFactory

---

• LatteFactory
• TemplatingFactory
• TemplateFactory

Maybe?

[mrtnzlml]

Yeah, I was thinking about this approach but I want to know more opinions (from more people) first... :)

[TomasVotruba]

Please discuss under PR #159, as it is suggested solution and it's more relevant there.
Thank you