Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP List renderer #283

Merged
merged 3 commits into from
Jul 18, 2024
Merged

IP List renderer #283

merged 3 commits into from
Jul 18, 2024

Conversation

iqbalaydrus
Copy link
Contributor

In json format, IP list is now formatted as Hex. This PR will format ip address to the standard notation

@lspgn
Copy link
Member

lspgn commented Jan 26, 2024

Hello,
Thank you for suggesting this change.
Is there a capture you could provide in order for me to test this?

@iqbalaydrus
Copy link
Contributor Author

Sure

mplsiplist.pcap.zip

add default rendering for MplsIp is enough
@iqbalaydrus
Copy link
Contributor Author

Sorry, I was under the impression that the renderer doesn't accept slice/list type. Updated the PR to just include default MplsIp to use ip renderer

@lspgn lspgn merged commit 2427a56 into netsampler:main Jul 18, 2024
@lspgn
Copy link
Member

lspgn commented Jul 18, 2024

Thank you @iqbalaydrus

lspgn pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants