Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schedTriggers #44

Merged
merged 5 commits into from
Jul 12, 2024
Merged

add schedTriggers #44

merged 5 commits into from
Jul 12, 2024

Conversation

QiufangMa
Copy link
Collaborator

schedValue is "The value which is written to the MIB object pointed to by
schedVariable when the scheduler invokes an action."
schedVariable is "An object identifier pointing to a local MIB variable
which resolves to an ASN.1 primitive type of INTEGER."
both seem parameters specific to SNMP, and thus may be omitted from the mapping?

Meanwhile, schedTriggers : "This variable counts the number of attempts (either
successful or failed) to invoke the scheduled action." this seems to be related to leaf "counter" inside schedule-status grouping...

@QiufangMa QiufangMa requested a review from boucadair July 11, 2024 11:32
@boucadair
Copy link
Collaborator

I agree that schedValue is not applicable in our context. This is why we had it "not supported" in the table. Instead of deleting the entry, we may s/not supported/not applicable.

For schedTriggers, we do have both successful and failures in separate counters. Don't see the value to support this as a separate parameter. We may indicate in the table that it is covered by failure-counter + counter.

@@ -469,7 +469,7 @@ can be mapped to YANG parameters.
|schedLastFailure| Not Supported |
|schedLastFailed| last-failed-occurrence|
|schedStorageType| Not Supported |
|schedValue| Not Supported |
|schedTriggers| counter |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|schedTriggers| counter |
|schedValue| Not Applicable|
|schedTriggers| counter/failure-counter |

@QiufangMa
Copy link
Collaborator Author

QiufangMa commented Jul 11, 2024

I agree that schedValue is not applicable in our context. This is why we had it "not supported" in the table. Instead of deleting the entry, we may s/not supported/not applicable.

If this is the case, then i guess schedVariable should also be added in the table?

@QiufangMa QiufangMa requested a review from boucadair July 11, 2024 12:17
@boucadair
Copy link
Collaborator

schedVariable

Agree, assuming we say not applicable.

Copy link
Collaborator

@boucadair boucadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@QiufangMa QiufangMa merged commit ead862a into netmod-wg:main Jul 12, 2024
2 checks passed
@QiufangMa QiufangMa changed the title add schedTriggers and remove schedValue add schedTriggers Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants