This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: always transform V2 functions #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Oct 9, 2023
| * Returns the module format that should be used when transpiling a TypeScript | ||
| * file. | ||
| */ | ||
| const getTSModuleFormat = async ( |
There was a problem hiding this comment.
This is now called getModuleFormat in transformer.ts.
eduardoboucas
commented
Oct 9, 2023
| rewrites: Map<string, string> | ||
| } | ||
|
|
||
| const getTypeScriptTransformer = async ( |
There was a problem hiding this comment.
This is now called getTransformer in transformer.ts.
eduardoboucas
commented
Oct 9, 2023
| path: string | ||
| } | ||
|
|
||
| export const transpileTS = async ({ bundle = false, config, format, name, path }: TranspileTSOptions) => { |
There was a problem hiding this comment.
This is now called transform in transformer.ts.
⏱ Benchmark resultsComparing with 1eccedc largeDepsEsbuild: 2.6s⬇️ 9.45% decrease vs. 1eccedc Legend
largeDepsNft: 8.1s⬇️ 4.42% decrease vs. 1eccedc Legend
largeDepsZisi: 15.9s⬆️ 0.06% increase vs. 1eccedc Legend
|
Skn0tt
approved these changes
Oct 10, 2023
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
* feat: always bundle V2 functions * refactor: rename to `transformer` * refactor: always bundle * refactor: update conditions * chore: update tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I realised that we were only transforming V2 functions (i.e. running them through esbuild) when the extension was a TypeScript extension. But we should also do it for JavaScript functions, since bundling local imports is essential to ensure imports between ESM and CJS work as expected.
I ended up renaming the "TS transformer" to a generic transformer, and I moved it into its own file.