chore: pull in v0.13.13 from upstream #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bazel nogo (Go lint config) errored when I tried to compile esbuild:
compilepkg: nogo: errors found by nogo during build-time code analysis:
external/com_github_evanw_esbuild/internal/bundler/linker.go:3309:27:
exporting a pointer for the loop variable stmt (export_loop_ref)
The simplified code nogo complains about is:
for _, stmt := range partStmts {
stmt.Data = &js_ast.SImport{
StarNameLoc: &stmt.Loc,
}
}
The problem is `&stmt.Loc` points to the mutated loop variable `stmt`. After
the loop iteration ends, all stored pointers will point to the last value of
`partStmts[-1].Loc`.
An alternative solution is to shadow `stmt` at the beginning of the loop, but
this felt cleaner:
stmt := stmt
The lint rule is defined by https://github.com/kyoh86/exportloopref.
eduardoboucas
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in all the changes since v0.13.13 from upstream. There were quite some merge conflicts in the process, but most were easily resolvable. CI is green, which gives me some confidence that everything went alright :) The tests for
onDynamicImportare also still part of the repository after merging, so we know that our changes weren't deleted at some point during the merge.closes https://github.com/netlify/pod-serverless/issues/42