-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sites): Repo shorthand for create:site-template #4382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @iib0011, very cool 🚀
Can we declare the repo as an "official" optional command argument? See https://github.com/tj/commander.js/tree/02a124c7d58dbae2ef11f9284b2c68ad94f6dc8b#command-arguments
That should add it to the help and docs and allow better access to it in the command action
Ok. Let me change it
…On Mon, Feb 28, 2022 at 2:36 PM Erez Rokah ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks @iib0011 <https://github.com/iib0011>, very cool 🚀
Can we declare the repo as an "official" optional command argument? See
https://github.com/tj/commander.js/tree/02a124c7d58dbae2ef11f9284b2c68ad94f6dc8b#command-arguments
That should add it to the help and docs and allow better access to it in
the command action
—
Reply to this email directly, view it on GitHub
<#4382 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOBJ6LA2T3F5YIQKPTUB2FTU5N257ANCNFSM5PLLZ5ZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks, it seems this PR has some unnecessary changes (e.g. types and line removals). Do you mind reverting them? |
Okay |
@erezrokah Yes. It looks good to me. |
Summary
Fixes #4326
We can now use:
ntl sites:create-template nextjs-blog-theme
which will expand to github.com/netlify-templates/nextjs-blog-theme
And this:
ntl sites:create-template jlengstorf/my-template
which will expand to github.com/jlengstorf/my-template