Add id-length ESLint rule
#1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
erezrokah
suggested changes
Oct 20, 2020
src/commands/dev/index.js
Outdated
| @@ -92,7 +92,7 @@ async function startFrameworkServer({ settings, log, exit }) { | |||
| return ps | |||
| } | |||
|
|
|||
| const getAddonsUrlsAndAddEnvVariablesToProcessEnv = async ({ api, site, flags }) => { | |||
There was a problem hiding this comment.
This name is intentionally long since the function does multiple things (which it shouldn't).
I'm going to refactor it soon, probably as a part of #1331
| @@ -16,7 +16,7 @@ exports.handler = async function (event) { | |||
| }, | |||
| user_metadata: { | |||
| ...user.user_metadata, // append current user metadata | |||
| custom_data_from_function: 'hurray this is some extra metadata', | |||
| custom_data_from_func: 'hurray this is some extra metadata', | |||
There was a problem hiding this comment.
Not sure if we want to keep the original due to https://www.netlify.com/blog/2019/02/21/the-role-of-roles-and-how-to-set-them-in-netlify-identity/
|
Answered this in the PR for Netlify Build, let's solve this first: netlify/build#1982 (comment) |
ehmicky
force-pushed
the
chore/lint-id-length
branch
from
57ae7a5 to
d4c2970
Compare
|
Thanks @erezrokah! |
ehmicky
force-pushed
the
chore/lint-id-length
branch
from
d4c2970 to
7af8987
Compare
|
Rebased. Does this look good @erezrokah ? |
erezrokah
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
id-lengthESLint rule.See also netlify/build#1982
Single-letter variable names makes reading code less clear.