refactor: cleanup createSiteAddon function #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
ehmicky
reviewed
Oct 6, 2020
src/commands/functions/create.js
Outdated
| const addonCreated = await createSiteAddon(api.accessToken, addonName, siteId, siteData, this.log) | ||
| if (addonCreated) { | ||
| if (addonDidInstall) { | ||
| const { addEnvVariables } = require('../../utils/dev') |
There was a problem hiding this comment.
Do we have a good reason to dynamically load require() here (I think not)?
There was a problem hiding this comment.
I'm actually not sure why this is there. Looks it's only relevant when calling addonDidInstall a bit after and addEnvVariables is also called after installAddons.
ehmicky
reviewed
Oct 6, 2020
| // const manifest = await getAddonManifest(addonName, accessToken); | ||
|
|
||
| const configValues = rawFlags | ||
| // if (manifest.config) { |
ehmicky
reviewed
Oct 6, 2020
|
|
||
| /** main section - shamelessly adapted from CLI. we can extract and dedupe later. */ | ||
| /** but we can DRY things up later. */ |
ehmicky
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #310 and #1331
Wanted to fix #1331, but couldn't do it since the addons code doesn't allow getting the env variables easily at the moment:
I going to do some refactoring first so we can have
cli/src/utils/dev.js
Line 25 in b88cf6d
process.envI removed a bunch of outdated comments from
utils/addons.jsand did some code cleanup.Note that part of that function is duplicated from:
cli/src/commands/addons/create.js
Line 155 in b88cf6d
I follow up in another PR.
Also changed some code in
functions/create.jsto useasync/awaitinstead of promise nesting and added a missingawaitThe code itself is used when running
netlify functions:createand will add missing addons depending on the function template.For example if you install a
faunatemplate it adds thefaunaaddon