Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate framework-info to TS and vitest and enable more strictness #4819

Merged
merged 12 commits into from
Feb 3, 2023
Merged

fix: migrate framework-info to TS and vitest and enable more strictness #4819

merged 12 commits into from
Feb 3, 2023

Conversation

danez
Copy link
Contributor

@danez danez commented Jan 12, 2023 •
edited
Loading

Summary

Noticed these things while looking into why frameworks are not detected anymore.

Seems that framework-info cannot be converted to typescript because in package.json exports points to ./src/

@danez danez self-assigned this Jan 12, 2023
@github-actions
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@danez danez force-pushed the framework-info branch 2 times, most recently from c7783b9 to d255f22 Compare January 12, 2023 22:48
@danez danez changed the title fix: version is not part of read-pkg-up result fix: fix some undefined fields Jan 12, 2023
@danez danez changed the title fix: fix some undefined fields fix: fix undefined fields in framework-info Jan 13, 2023
@danez danez changed the title fix: fix undefined fields in framework-info fix: handle undefined fields in framework-info Jan 13, 2023
@danez danez changed the title fix: handle undefined fields in framework-info fix: migrate framework-info to TS and vitest and enable more strictness Jan 16, 2023
@danez danez requested a review from lukasholzer January 16, 2023 14:35
@danez
Copy link
Contributor Author

danez commented Jan 16, 2023

All migrated to TS and vitest

@danez danez requested review from a team January 16, 2023 15:09
@danez danez mentioned this pull request Jan 18, 2023
Merged
@danez danez marked this pull request as draft January 18, 2023 10:26
@danez
Copy link
Contributor Author

danez commented Jan 18, 2023

waiting for #4828

@danez danez marked this pull request as ready for review January 18, 2023 15:06
lukasholzer
lukasholzer previously approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@lukasholzer lukasholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for doing this tremendous amount of extra work here!

Awesome! 🥳

packages/framework-info/package.json Outdated Show resolved Hide resolved
@danez danez requested a review from lukasholzer February 3, 2023 13:20
@danez danez added the automerge label Feb 3, 2023
@kodiakhq kodiakhq bot merged commit 5acb25b into main Feb 3, 2023
@kodiakhq kodiakhq bot deleted the framework-info branch February 3, 2023 14:00
@netlify-circleci netlify-circleci mentioned this pull request Feb 3, 2023
Merged
danez added a commit that referenced this pull request Feb 9, 2023
@danez
fix: respect manual order of frameworks
8d69279 
This is a regression of #4819
@danez danez mentioned this pull request Feb 9, 2023
Merged
5 tasks
danez added a commit that referenced this pull request Feb 9, 2023
@danez
fix: respect manual order of frameworks (#4858)
45c0cf2 
This is a regression of #4819
@netlify-circleci netlify-circleci mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasholzer lukasholzer lukasholzer approved these changes

@ericapisani ericapisani Awaiting requested review from ericapisani

Assignees

@danez danez

Labels
Adds or modifies js files automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danez @lukasholzer