Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project delivery #2
base: apa/delivery
Are you sure you want to change the base?
Project delivery #2
Changes from all commits
38f5cf6
3cce47d
011753d
678ab71
b020e13
514f590
1ff1094
e4f5060
24a84fd
6f27b0d
fd5da23
9d1cbb9
5629537
06fd463
f8d9cae
73f5ce9
d423cc7
f70602c
6f92c27
ab532bb
f44a8d1
ce96207
0b48b4f
f7e50ee
36ffb80
8a08616
533c221
1700b6a
cff6d93
e10ba30
6b706bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Say here how many components (and which ones they are) you have to install, so that reader is aware of what it needs to do (at high-level). Then, structure the doc in such a way that there's a sub-sub-section for each component.
Note: the "installation" section should focus on installation. However, we need another section such as "architecture", which explains the logical blocks you're using, what they are used for, and how they interact to each other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the subsections + a general view on the components to install.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about if this path does not exist on the target machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first part is the volume mount I created, while the
openvpn/openvpn-status.log
refers to a file that is present in the OpenVPN installation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the name "openvpn" repeated twice here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is in the golang implementation of the exporter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am definitely missing how we can create users that will use this VPN service. It is definitely a very important point given that, without that information, your service looks pretty much useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was state in the part that says
which also contains the commands to run for generating the certificates for a new user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find any explanation about how traffic is routed within the service. Do we have to enable the IP forwarding on the Pod? In either case (either YES or NO), why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ip forwarding needs to be set, otherwise traffic stops at the gateway. I added the functionality of setting it automatically when deploying (I point it out in the README section about the list of modification I made).
I have also added a pointer to an explanation of OpenVPN routing, if you think it can be useful I can elaborate a bit on OpenVPN routing in general.