Merge pull request #6 from netbrothers-gmbh/issue-5

Issue 5

CHANGELOG.md

@@ -1,6 +1,11 @@
 Changelog for NetBrothers Versions 
 ===================================
 
+Version 0.0.4 - 18.02.2022
+----------------------------------
+- Fixing Bug "There is no active transaction".
+- Upgrading Version-Number
+
 Version 0.0.3 - 03.02.2022
 ----------------------------------
 - Adding "?ExtensionInterface" as a native return type declaration in class `NetBrothers\VersionBundle\NetBrothersVersionBundle`.

composer.json

@@ -1,7 +1,7 @@
 {
   "name": "netbrothers-gmbh/version-bundle",
   "description": "SymfonyBundle for handling versions based on triggers in mysql with doctrine",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "keywords": ["symfony","bundle","versioning","doctrine","mysql"],
   "type": "symfony-bundle",
   "require": {

src/Services/Sql/ExecuteService.php

@@ -57,17 +57,13 @@ public function execute(array $sql = []): bool
             throw new \Exception(__CLASS__ . ': only sql-statements packed in array can be executed.');
         }
         if (0 < count($sql)) {
-            $this->connection->beginTransaction();
             try {
                 foreach ($sql as $query) {
                     if (true !== $this->_execute($query)) {
                         return false;
                     }
                 }
-                $this->connection->commit();
             } catch (\Exception $e) {
-                $this->connection->rollBack();
-                $this->connection->setAutoCommit(true);
                 throw new \Exception("Cannot commit", 500, $e);
             }
         }
@@ -86,8 +82,6 @@ private function _execute(string $query): bool
             $result = $statement->executeQuery();
             return true;
         } catch ( DriverException $e) {
-            $this->connection->rollBack();
-            $this->connection->setAutoCommit(true);
             $this->errMsg = "Cannot execute SQL: $query";
             return false;
         }