core/endpoint: Get choices from PUT if POST missing #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BenoitKnecht Can you please add a test case for this? |
If the API token is not allowed to POST on a particular endpoint, choices won't be returned in `.actions.POST`, but we can still get them in `.actions.PUT`. This commit falls back to getting choices from `.actions.PUT` instead of raising an exception when `.actions.POST` is missing. Signed-off-by: Benoît Knecht <[email protected]>
Make sure we can get choices from the `PUT` action when the API doesn't allow `POST`, and that the `POST` data takes precedence over the `PUT` data. Signed-off-by: Benoît Knecht <[email protected]>
BenoitKnecht
force-pushed
the
get-choices-from-post-or-put
branch
from
dddd5fa to
0f9a463
Compare
|
@arthanson Sorry for the massive delay, I somehow missed your message. I've added a couple of unit tests, let me know if that's good enough. |
|
@arthanson Could you take another look at this PR? I'd really love to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #591
If the API token is not allowed to POST on a particular endpoint, choices won't be returned in
.actions.POST, but we can still get them in.actions.PUT.This commit falls back to getting choices from
.actions.PUTinstead of raising an exception when.actions.POSTis missing.